From 1a929d8c3620a9006780243ccf9710dd935a2b5b Mon Sep 17 00:00:00 2001
From: Juha Heinanen <jh@tutpro.com>
Date: Tue, 7 Aug 2018 21:22:57 +0300
Subject: [PATCH] improved About activity

---
 .../com/tutpro/baresip/AboutActivity.kt       |  7 +++---
 app/src/main/res/layout/activity_about.xml    | 24 +++++++++++++------
 app/src/main/res/values/strings.xml           |  6 ++---
 3 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/app/src/main/kotlin/com/tutpro/baresip/AboutActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/AboutActivity.kt
index 25560903..cec7ce42 100644
--- a/app/src/main/kotlin/com/tutpro/baresip/AboutActivity.kt
+++ b/app/src/main/kotlin/com/tutpro/baresip/AboutActivity.kt
@@ -2,6 +2,7 @@ package com.tutpro.baresip
 
 import android.app.Activity
 import android.content.Intent
+import android.graphics.Color
 import android.os.Bundle
 import android.support.v7.app.AppCompatActivity
 import android.view.MenuItem
@@ -12,9 +13,9 @@ class AboutActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_about)
-        val aboutView = findViewById(R.id.aboutText) as TextView
-        aboutView.isEnabled = false
-        aboutView.text = getText(R.string.aboutText)
+        val aboutText = findViewById(R.id.aboutText) as TextView
+        aboutText.text = getText(R.string.aboutText)
+        aboutText.setTextColor(Color.BLACK)
     }
 
     override fun onOptionsItemSelected(item: MenuItem): Boolean {
diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml
index 9153cded..0436159b 100644
--- a/app/src/main/res/layout/activity_about.xml
+++ b/app/src/main/res/layout/activity_about.xml
@@ -1,17 +1,27 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
-    android:layout_width="match_parent"
-    android:layout_height="match_parent"
+    android:orientation="vertical"
+    android:layout_width="fill_parent"
+    android:layout_height="fill_parent"
     android:paddingBottom="@dimen/activity_vertical_margin"
     android:paddingLeft="@dimen/activity_horizontal_margin"
     android:paddingRight="@dimen/activity_horizontal_margin"
     android:paddingTop="@dimen/activity_vertical_margin"
-    tools:context="com.tutpro.baresip.AboutActivity">
+    tools:context=".AboutActivity">
 
-    <EditText
+    <ScrollView
+        android:id="@+id/aboutView"
+        android:layout_width="fill_parent"
+        android:layout_height="wrap_content"
+        android:scrollbars="vertical"
+        android:fillViewport="true" >
+
+    <TextView
         android:id="@+id/aboutText"
         android:layout_width="fill_parent"
-        android:layout_height="fill_parent" />
+        android:layout_height="wrap_content" />
 
-</RelativeLayout>
+    </ScrollView>
+
+</LinearLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 7fa316a9..44d363dd 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -9,9 +9,9 @@
         - start by creating an account (click item titles for help)\n
         - usually there is no need to edit the config\n
         - in config, dns_server by default points to 8.8.8.8:53 for Android 8+ usage\n
-        - contacts and history entries can be removed and added to contacts by long clicks\n
-        - contacts can be removed by long clicks\n
-        - call click when callee has not been given can be used for re-dial\n\n
+        - peers of calls and messages can be added to contacts by long clicks\n
+        - long clicks can also be used to remove calls, messages, and contacts\n
+        - call click when callee has not been given can be used for re-dial\n
     </string>
     <string name="noAccounts">No accounts</string>
     <string name="dispName">Name (if any) used in From URI of outbound requests.</string>