diff --git a/app/src/main/kotlin/com/tutpro/baresip/AccountActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/AccountActivity.kt index 59052b23..02cfe227 100644 --- a/app/src/main/kotlin/com/tutpro/baresip/AccountActivity.kt +++ b/app/src/main/kotlin/com/tutpro/baresip/AccountActivity.kt @@ -98,6 +98,8 @@ class AccountActivity : AppCompatActivity() { initLayoutFromAccount(acc) + bindTitles() + } private fun initAccountFromConfig(ctx: AccountActivity) { @@ -637,76 +639,102 @@ class AccountActivity : AppCompatActivity() { super.onPause() } - fun onClick(v: View) { - when (v) { - binding.DisplayNameTitle -> { - Utils.alertView(this, getString(R.string.display_name), - getString(R.string.display_name_help)) - } - binding.AuthUserTitle -> { - Utils.alertView(this, getString(R.string.authentication_username), - getString(R.string.authentication_username_help)) - } - binding.AuthPassTitle -> { - Utils.alertView(this, getString(R.string.authentication_password), - getString(R.string.authentication_password_help)) - } - binding.OutboundProxyTitle -> { - Utils.alertView(this, getString(R.string.outbound_proxies), - getString(R.string.outbound_proxies_help)) - } - binding.RegTitle -> { - Utils.alertView(this, getString(R.string.register), - getString(R.string.register_help)) - } - binding.AudioCodecsTitle -> { - val i = Intent(this, CodecsActivity::class.java) - val b = Bundle() - b.putString("aor", aor) - b.putString("media", "audio") - i.putExtras(b) - startActivity(i) - } - binding.MediaNatTitle -> { - Utils.alertView(this, getString(R.string.media_nat), - getString(R.string.media_nat_help)) - } - binding.StunServerTitle -> { - Utils.alertView(this, getString(R.string.stun_server), - getString(R.string.stun_server_help)) - } - binding.StunUserTitle -> { - Utils.alertView(this, getString(R.string.stun_username), - getString(R.string.stun_username_help)) - } - binding.StunPassTitle -> { - Utils.alertView(this, getString(R.string.stun_password), - getString(R.string.stun_password_help)) - } - binding.MediaEncTitle -> { - Utils.alertView(this, getString(R.string.media_encryption), - getString(R.string.media_encryption_help)) - } - binding.PreferIPv6MediaTitle -> { - Utils.alertView(this, getString(R.string.prefer_ipv6_media), - getString(R.string.prefer_ipv6_media_help)) - } - binding.DtmfModeTitle -> { - Utils.alertView(this, getString(R.string.dtmf_mode), - getString(R.string.dtmf_mode_help)) - } - binding.AnswerModeTitle -> { - Utils.alertView(this, getString(R.string.answer_mode), - getString(R.string.answer_mode_help)) - } - binding.VoicemailUriTitle -> { - Utils.alertView(this, getString(R.string.voicemail_uri), - getString(R.string.voicemain_uri_help)) - } - binding.DefaultTitle -> { - Utils.alertView(this, getString(R.string.default_account), - getString(R.string.default_account_help)) - } + private fun bindTitles() { + binding.DisplayNameTitle.setOnClickListener{ + Utils.alertView(this, getString(R.string.display_name), + getString(R.string.display_name_help)) + } + binding.AuthUserTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.authentication_username), + getString(R.string.authentication_username_help) + ) + } + binding.AuthPassTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.authentication_password), + getString(R.string.authentication_password_help) + ) + } + binding.OutboundProxyTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.outbound_proxies), + getString(R.string.outbound_proxies_help) + ) + } + binding.RegTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.register), + getString(R.string.register_help) + ) + } + binding.AudioCodecsTitle.setOnClickListener { + val i = Intent(this, CodecsActivity::class.java) + val b = Bundle() + b.putString("aor", aor) + b.putString("media", "audio") + i.putExtras(b) + startActivity(i) + } + binding.MediaNatTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.media_nat), + getString(R.string.media_nat_help) + ) + } + binding.StunServerTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.stun_server), + getString(R.string.stun_server_help) + ) + } + binding.StunUserTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.stun_username), + getString(R.string.stun_username_help) + ) + } + binding.StunPassTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.stun_password), + getString(R.string.stun_password_help) + ) + } + binding.MediaEncTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.media_encryption), + getString(R.string.media_encryption_help) + ) + } + binding.PreferIPv6Media.setOnClickListener { + Utils.alertView( + this, getString(R.string.prefer_ipv6_media), + getString(R.string.prefer_ipv6_media_help) + ) + } + binding.DtmfModeTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.dtmf_mode), + getString(R.string.dtmf_mode_help) + ) + } + binding.AnswerModeTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.answer_mode), + getString(R.string.answer_mode_help) + ) + } + binding.VoicemailUriTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.voicemail_uri), + getString(R.string.voicemain_uri_help) + ) + } + binding.DefaultTitle.setOnClickListener { + Utils.alertView( + this, getString(R.string.default_account), + getString(R.string.default_account_help) + ) } } diff --git a/app/src/main/kotlin/com/tutpro/baresip/AudioActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/AudioActivity.kt index 30e56c4f..d70b6bb4 100644 --- a/app/src/main/kotlin/com/tutpro/baresip/AudioActivity.kt +++ b/app/src/main/kotlin/com/tutpro/baresip/AudioActivity.kt @@ -5,7 +5,6 @@ import android.util.TypedValue import android.view.Gravity import android.view.Menu import android.view.MenuItem -import android.view.View import android.widget.* import androidx.appcompat.app.AppCompatActivity import androidx.core.content.ContextCompat @@ -84,6 +83,8 @@ class AudioActivity : AppCompatActivity() { oldAec = aecCv.contains("webrtc_aecm.so") aec.isChecked = oldAec + bindTitles() + } override fun onCreateOptionsMenu(menu: Menu): Boolean { @@ -198,24 +199,22 @@ class AudioActivity : AppCompatActivity() { super.onBackPressed() } - fun onClick(v: View) { - when (v) { - binding.AudioModulesTitle -> { - Utils.alertView(this, getString(R.string.audio_modules_title), - getString(R.string.audio_modules_help)) - } - binding.OpusBitRateTitle -> { - Utils.alertView(this, getString(R.string.opus_bit_rate), - getString(R.string.opus_bit_rate_help)) - } - binding.OpusPacketLossTitle -> { - Utils.alertView(this, getString(R.string.opus_packet_loss), - getString(R.string.opus_packet_loss_help)) - } - binding.AecTitle -> { - Utils.alertView(this, getString(R.string.aec), - getString(R.string.aec_help)) - } + private fun bindTitles() { + binding.AudioModulesTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.audio_modules_title), + getString(R.string.audio_modules_help)) + } + binding.OpusBitRateTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.opus_bit_rate), + getString(R.string.opus_bit_rate_help)) + } + binding.OpusPacketLossTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.opus_packet_loss), + getString(R.string.opus_packet_loss_help)) + } + binding.AecTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.aec), + getString(R.string.aec_help)) } } diff --git a/app/src/main/kotlin/com/tutpro/baresip/CodecsActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/CodecsActivity.kt index 5d303ee8..27ac313e 100644 --- a/app/src/main/kotlin/com/tutpro/baresip/CodecsActivity.kt +++ b/app/src/main/kotlin/com/tutpro/baresip/CodecsActivity.kt @@ -86,6 +86,15 @@ class CodecsActivity : AppCompatActivity() { } } + binding.CodecsTitle.setOnClickListener { + if (media == "audio") + Utils.alertView(this, getString(R.string.audio_codecs), + getString(R.string.audio_codecs_help)) + else + Utils.alertView(this, getString(R.string.video_codecs), + getString(R.string.video_codecs_help)) + } + } override fun onCreateOptionsMenu(menu: Menu): Boolean { @@ -168,17 +177,4 @@ class CodecsActivity : AppCompatActivity() { super.onPause() } - fun onClick(v: View) { - when (v) { - binding.CodecsTitle -> { - if (media == "audio") - Utils.alertView(this, getString(R.string.audio_codecs), - getString(R.string.audio_codecs_help)) - else - Utils.alertView(this, getString(R.string.video_codecs), - getString(R.string.video_codecs_help)) - } - } - } - } diff --git a/app/src/main/kotlin/com/tutpro/baresip/ConfigActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/ConfigActivity.kt index 7c7c330a..5d6bf8ab 100644 --- a/app/src/main/kotlin/com/tutpro/baresip/ConfigActivity.kt +++ b/app/src/main/kotlin/com/tutpro/baresip/ConfigActivity.kt @@ -271,6 +271,8 @@ class ConfigActivity : AppCompatActivity() { } } + bindTitles() + } override fun onCreateOptionsMenu(menu: Menu): Boolean { @@ -442,54 +444,52 @@ class ConfigActivity : AppCompatActivity() { } - fun onClick(v: View) { - when (v) { - binding.AutoStartTitle -> { - Utils.alertView(this, getString(R.string.start_automatically), - getString(R.string.start_automatically_help)) - } - binding.ListenAddressTitle -> { - Utils.alertView(this, getString(R.string.listen_address), - getString(R.string.listen_address_help)) - } - binding.DnsServersTitle -> { - Utils.alertView(this, getString(R.string.dns_servers), - getString(R.string.dns_servers_help)) - } - binding.CertificateFileTitle -> { - Utils.alertView(this, getString(R.string.tls_certificate_file), - getString(R.string.tls_certificate_file_help)) - } - binding.VerifyServerTitle -> { - Utils.alertView(this, getString(R.string.verify_server), - getString(R.string.verify_server_help)) - } - binding.CAFileTitle -> { - Utils.alertView(this, getString(R.string.tls_ca_file), - getString(R.string.tls_ca_file_help)) - } - binding.AudioTitle -> { - startActivity(Intent(this, AudioActivity::class.java)) - } - binding.VolumeTitle -> { - Utils.alertView(this, getString(R.string.default_call_volume), - getString(R.string.default_call_volume_help)) - } - binding.DarkThemeTitle -> { - Utils.alertView(this, getString(R.string.dark_theme), - getString(R.string.dark_theme_help)) - } - binding.DebugTitle -> { - Utils.alertView(this, getString(R.string.debug), getString(R.string.debug_help)) - } - binding.SipTraceTitle -> { - Utils.alertView(this, getString(R.string.sip_trace), - getString(R.string.sip_trace_help)) - } - binding.ResetTitle -> { - Utils.alertView(this, getString(R.string.reset_config), - getString(R.string.reset_config_help)) - } + fun bindTitles() { + binding.AutoStartTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.start_automatically), + getString(R.string.start_automatically_help)) + } + binding.ListenAddressTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.listen_address), + getString(R.string.listen_address_help)) + } + binding.DnsServersTitle .setOnClickListener { + Utils.alertView(this, getString(R.string.dns_servers), + getString(R.string.dns_servers_help)) + } + binding.CertificateFileTitle .setOnClickListener { + Utils.alertView(this, getString(R.string.tls_certificate_file), + getString(R.string.tls_certificate_file_help)) + } + binding.VerifyServerTitle .setOnClickListener { + Utils.alertView(this, getString(R.string.verify_server), + getString(R.string.verify_server_help)) + } + binding.CAFileTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.tls_ca_file), + getString(R.string.tls_ca_file_help)) + } + binding.AudioTitle .setOnClickListener { + startActivity(Intent(this, AudioActivity::class.java)) + } + binding.VolumeTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.default_call_volume), + getString(R.string.default_call_volume_help)) + } + binding.DarkThemeTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.dark_theme), + getString(R.string.dark_theme_help)) + } + binding.DebugTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.debug), getString(R.string.debug_help)) + } + binding.SipTraceTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.sip_trace), + getString(R.string.sip_trace_help)) + } + binding.ResetTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.reset_config), + getString(R.string.reset_config_help)) } } diff --git a/app/src/main/kotlin/com/tutpro/baresip/ContactActivity.kt b/app/src/main/kotlin/com/tutpro/baresip/ContactActivity.kt index 5a095d44..f7268204 100644 --- a/app/src/main/kotlin/com/tutpro/baresip/ContactActivity.kt +++ b/app/src/main/kotlin/com/tutpro/baresip/ContactActivity.kt @@ -161,6 +161,11 @@ class ContactActivity : AppCompatActivity() { } + binding.AndroidTitle.setOnClickListener { + Utils.alertView(this, getString(R.string.android), + getString(R.string.android_contact_help)) + } + Utils.addActivity("contact,$newContact,$uOrI") } @@ -319,13 +324,6 @@ class ContactActivity : AppCompatActivity() { } - fun onClick(v: View) { - when (v) { - binding.AndroidTitle -> - Utils.alertView(this, getString(R.string.android), getString(R.string.android_contact_help)) - } - } - private fun showTextAvatar(name: String, color: Int) { textAvatarView.visibility = View.VISIBLE cardAvatarView.visibility = View.GONE diff --git a/app/src/main/res/layout/activity_account.xml b/app/src/main/res/layout/activity_account.xml index 49f93d03..0ccf6ffd 100644 --- a/app/src/main/res/layout/activity_account.xml +++ b/app/src/main/res/layout/activity_account.xml @@ -31,7 +31,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="18sp" - android:onClick="onClick" android:text="@string/display_name" > @@ -50,7 +49,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="18sp" - android:onClick="onClick" android:text="@string/authentication_username" > @@ -69,7 +67,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="18sp" - android:onClick="onClick" android:text="@string/authentication_password" > @@ -93,7 +90,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="18sp" - android:onClick="onClick" android:text="@string/outbound_proxies" > @@ -128,7 +124,6 @@ android:layout_alignParentStart="true" android:layout_toStartOf="@id/Register" android:textSize="18sp" - android:onClick="onClick" android:text="@string/register" > @@ -158,7 +152,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/media_encryption" > @@ -175,7 +168,6 @@ android:layout_height="wrap_content" android:paddingTop="16dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/media_nat" > @@ -192,7 +184,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/stun_server" > @@ -213,7 +204,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/stun_username" > @@ -233,7 +223,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/stun_password" > @@ -265,7 +254,6 @@ android:layout_toStartOf="@id/PreferIPv6Media" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/prefer_ipv6_media" > @@ -301,7 +288,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/answer_mode" > @@ -318,7 +304,6 @@ android:layout_height="wrap_content" android:paddingTop="10dp" android:textSize="18sp" - android:onClick="onClick" android:text="@string/voicemail_uri" > @@ -344,7 +329,6 @@ android:layout_alignParentStart="true" android:layout_toStartOf="@id/Default" android:textSize="18sp" - android:onClick="onClick" android:text="@string/default_account" > diff --git a/app/src/main/res/layout/activity_config.xml b/app/src/main/res/layout/activity_config.xml index ddbb1f1e..afe7044c 100644 --- a/app/src/main/res/layout/activity_config.xml +++ b/app/src/main/res/layout/activity_config.xml @@ -28,7 +28,6 @@ android:layout_centerVertical="true" android:layout_toStartOf="@id/AutoStart" android:textSize="18sp" - android:onClick="onClick" android:text="@string/start_automatically" > @@ -66,7 +64,6 @@ android:id="@+id/DnsServersTitle" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:onClick="onClick" android:text="@string/dns_servers" android:textSize="18sp"> @@ -94,7 +91,6 @@ android:layout_centerVertical="true" android:layout_toStartOf="@id/CertificateFile" android:textSize="18sp" - android:onClick="onClick" android:text="@string/tls_certificate_file" > @@ -186,7 +179,6 @@ android:layout_centerVertical="true" android:layout_toStartOf="@id/VolumeSpinner" android:textSize="18sp" - android:onClick="onClick" android:text="@string/default_call_volume" >