Replaced remaining popBackStack() calls with navigateUp() calls

This commit is contained in:
Juha Heinanen
2025-12-30 03:03:11 +02:00
parent f1d7b046b8
commit d245b301e8
8 changed files with 15 additions and 17 deletions

View File

@ -97,12 +97,12 @@ fun NavGraphBuilder.accountScreenRoute(navController: NavController) {
AccountScreen( AccountScreen(
viewModel = viewModel, viewModel = viewModel,
navController = navController, navController = navController,
onBack = { navController.popBackStack() }, onBack = { navController.navigateUp() },
checkOnClick = { checkOnClick = {
val ok = checkOnClick(ctx, viewModel, ua) val ok = checkOnClick(ctx, viewModel, ua)
if (ok) { if (ok) {
if (reRegister) ua.reRegister() if (reRegister) ua.reRegister()
navController.popBackStack() navController.navigateUp()
} }
}, },
aor = aor, aor = aor,
@ -404,12 +404,12 @@ private fun AccountContent(
Api.account_set_auth_pass(ua.account.accp, password.value) Api.account_set_auth_pass(ua.account.accp, password.value)
password.value = "" password.value = ""
ua.reRegister() ua.reRegister()
navController.popBackStack() navController.navigateUp()
} }
}, },
cancelAction = { cancelAction = {
ua.reRegister() ua.reRegister()
navController.popBackStack() navController.navigateUp()
} }
) )
} }

View File

@ -93,7 +93,7 @@ fun AccountsScreen(navController: NavController) {
titleContentColor = MaterialTheme.colorScheme.onPrimary, titleContentColor = MaterialTheme.colorScheme.onPrimary,
), ),
navigationIcon = { navigationIcon = {
IconButton(onClick = { navController.popBackStack() }) { IconButton(onClick = { navController.navigateUp() }) {
Icon( Icon(
imageVector = Icons.AutoMirrored.Filled.ArrowBack, imageVector = Icons.AutoMirrored.Filled.ArrowBack,
contentDescription = null, contentDescription = null,

View File

@ -64,14 +64,14 @@ fun NavGraphBuilder.audioScreenRoute(
val ctx = LocalContext.current val ctx = LocalContext.current
AudioScreen( AudioScreen(
onBack = { onBack = {
navController.popBackStack() navController.navigateUp()
}, },
checkOnClick = { checkOnClick = {
val result = checkOnClick(ctx) // Your existing logic that returns true/false val result = checkOnClick(ctx) // Your existing logic that returns true/false
navController.previousBackStackEntry navController.previousBackStackEntry
?.savedStateHandle ?.savedStateHandle
?.set("audio_settings_result", result) ?.set("audio_settings_result", result)
navController.popBackStack() navController.navigateUp()
}, },
) )
} }

View File

@ -175,9 +175,7 @@ private fun TopAppBar(
windowInsets = WindowInsets(0, 0, 0, 0), windowInsets = WindowInsets(0, 0, 0, 0),
navigationIcon = { navigationIcon = {
IconButton( IconButton(
onClick = { onClick = { navController.navigateUp() }
navController.popBackStack()
}
) { ) {
Icon( Icon(
imageVector = Icons.AutoMirrored.Filled.ArrowBack, imageVector = Icons.AutoMirrored.Filled.ArrowBack,

View File

@ -605,7 +605,7 @@ private fun backAction(navController: NavController, account: Account, peerUri:
val aor = account.aor val aor = account.aor
Message.updateMessagesFromPearRead(aor, peerUri) Message.updateMessagesFromPearRead(aor, peerUri)
account.unreadMessages = Message.unreadMessages(aor) account.unreadMessages = Message.unreadMessages(aor)
navController.popBackStack() navController.navigateUp()
} }
private fun loadPeerMessages(aor: String, peerUri: String): List<Message> { private fun loadPeerMessages(aor: String, peerUri: String): List<Message> {

View File

@ -61,7 +61,7 @@ fun NavGraphBuilder.codecsScreenRoute(navController: NavController) {
val media = backStackEntry.arguments?.getString("media")!! val media = backStackEntry.arguments?.getString("media")!!
val account = UserAgent.ofAor(aor)?.account!! val account = UserAgent.ofAor(aor)?.account!!
CodecsScreen( CodecsScreen(
onBack = { navController.popBackStack() }, onBack = { navController.navigateUp() },
checkOnClick = { updatedCodecs -> checkOnClick = { updatedCodecs ->
val enabledCodecNames = updatedCodecs.filter { it.enabled.value }.map { it.name } val enabledCodecNames = updatedCodecs.filter { it.enabled.value }.map { it.name }
val codecList = Utils.implode(enabledCodecNames, ",") val codecList = Utils.implode(enabledCodecNames, ",")
@ -80,7 +80,7 @@ fun NavGraphBuilder.codecsScreenRoute(navController: NavController) {
} }
else else
Log.e(TAG, "Failed to set $aor codecs.") Log.e(TAG, "Failed to set $aor codecs.")
navController.popBackStack() navController.navigateUp()
}, },
aor = aor, aor = aor,
media = media media = media

View File

@ -257,7 +257,7 @@ private fun ContactsContent(
neutralAction.value = { neutralAction.value = {
if (ua != null) { if (ua != null) {
handleIntent(ctx, viewModel, intent, "message") handleIntent(ctx, viewModel, intent, "message")
navController.popBackStack() navController.navigateUp()
} }
} }
showDialog.value = true showDialog.value = true

View File

@ -102,13 +102,13 @@ fun NavGraphBuilder.settingsScreenRoute(
ctx = ctx, ctx = ctx,
navController = navController, navController = navController,
settingsViewModel = viewModel, settingsViewModel = viewModel,
onBack = { navController.popBackStack() }, onBack = { navController.navigateUp() },
checkOnClick = { checkOnClick = {
if (checkOnClick(ctx, viewModel)) { if (checkOnClick(ctx, viewModel)) {
if (restart) if (restart)
showRestartDialog.value = true showRestartDialog.value = true
else else
navController.popBackStack() navController.navigateUp()
} }
}, },
onRestartApp = onRestartApp onRestartApp = onRestartApp
@ -206,7 +206,7 @@ private fun SettingsScreen(
}, },
negativeButtonText = stringResource(R.string.cancel), negativeButtonText = stringResource(R.string.cancel),
onNegativeClicked = { onNegativeClicked = {
navController.popBackStack() navController.navigateUp()
} }
) )
} }